pod.yaml: add init container waiting for free port#197
pod.yaml: add init container waiting for free port#197openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/M
| - name: wait-for-host-port | ||
| image: ${IMAGE} | ||
| imagePullPolicy: IfNotPresent | ||
| command: ['/usr/bin/timeout', '100', "/bin/bash", "-c"] # 60 sec for graceful termination, 35 for minimum-termination-duration |
There was a problem hiding this comment.
@sttts I've copied 100 here, if you know any reason this should be shorter lemme know
There was a problem hiding this comment.
It can. We don't have graceful termination for kube-controller-manager. 10 or at most 30 secs would be a good number.
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
cleared via Slack... in this PR we still see controller manager trying to bind on the insecure port, @soltysh have PR that fixes wiring the flags, we can let this go and the other PR should fix passing the flags. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
5 participants
/assign @sttts